The Apache Haus Forum

Forum Topics => Apache 2.4 => Topic started by: Gregg on April 19, 2011, 05:53:34 AM

Title: goodbye mod_macro
Post by: Gregg on April 19, 2011, 05:53:34 AM
For now anyway. There's been another change to the API that has now broken mod_macro. I've been trying to figure out how to modify the module to work again but I'm not making any headway. I haven't completely given up but it's not looking good by the time the next beta comes out. It sucks, I use it and like that module. Oh well.
Title: Re: goodbye mod_macro
Post by: mario on April 19, 2011, 01:48:58 PM
that is just a single file. Not a monster like mod_fcgid  ;)  Can you tell what error message you get while compiling?
Title: Re: goodbye mod_macro
Post by: Gregg on April 20, 2011, 12:02:14 AM
Code: [Select]
static int array_getch(void * param)
{
  array_contents_t * ml = (array_contents_t *)param;
  char ** tab = (char **)ml->contents->elts;

  while (ml->char_index >= ml->length) { /* next element */
    if (ml->index >= ml->contents->nelts) {
      /* maybe update. */
      if (ml->next && ml->next->getch && next_one(ml)) {
        return ml->next->getch(ml->next->param);
      }
      return -1;
    }
    ml->index++;
    ml->char_index = 0;
    ml->length = ml->index >= ml->contents->nelts? 0: strlen(tab[ml->index]);
  }

  return tab[ml->index][ml->char_index++];
}

function through pointer on line blah blah, don't have one available at the moment but this is the offending line.

        return ml->next->getch(ml->next->param);

in httpd_config.h it used to be

int getch (void * params);

now it's

apr_status_t (*getch) (char *ch, void *param);

I can get it to compile but the module errors about a config problem. I'm sure this IS semi-simple it's just not showing itself to me.
Stefan mentioned ap_pcfg_open_custom() so I need to look into those changes, I'm just tired of looking at it right now. I have added a ifmodule for NOT mod_macro loaded to cover what was macro'd. When I feel like it I'll compile a latest svn download. But my head hurts even doing that at this point.


http://marc.info/?l=apache-httpd-dev&m=130289788707876&w=2
Title: Re: goodbye mod_macro
Post by: Gregg on April 20, 2011, 12:14:59 AM
I should probably add that one thing mentioned to me was well, the function array_getch in mod_macro may have to be rewritten, possibly try calling apr_getc directly, and a couple other things I can't remember but have written down at home.
Title: Re: goodbye mod_macro
Post by: fabien on February 04, 2012, 04:32:37 PM
For now anyway. There's been another change to the API that has now broken mod_macro.

I've updated mod_macro to try to conform to the new API. If someone could test, that would help, because I do not have an Apache 2.3 server running anywhere.

See http://www.coelho.net/mod_macro/ for my email.
Title: Re: goodbye mod_macro
Post by: Gregg on February 05, 2012, 03:10:02 AM
Hi Fabien,

Email on the way.
Title: Re: goodbye mod_macro
Post by: Gregg on February 08, 2012, 10:38:33 PM
Thanks to Fabien, mod_macro now works on 2.4 so for the next beta it will be included. I do expect the 2.4.1 to be beta, at least I'll be calling it beta till such time as the AcceptFilter issue is resolved regardless of the ASFs designation.